Fix bc compatiblity between ErrorRenderer FlattenException and Debug FlattenException #33916
Conversation
There was a problem hiding this comment.
Hi @alexander-schranz thanks for taking care of this, but I think we already have changed all the calls from FlattenException::create() to FlattenException::createFromThrowable() in 4.4 codebase. If your project or 3rd-party bundles use FlattenException::create() from Debug component for something, it must require symfony/debug package as a hard dependency instead of relying on it as a transitive one.
Thus, you'll be able to migrate without BC break. See discussion about this topic here #32873 (comment)
I'm 👎 on these changes.
|
@yceruto Thank you for clarification. I still would add the function as it don't really hurt if its there and for people who relying on this don't get hurt when they update from 4.3 and 4.4. |
|
|
||
| return static::createFromThrowable($exception, $statusCode, $headers); | ||
| } | ||
|
|
||
| public static function createFromThrowable(\Throwable $exception, int $statusCode = null, array $headers = []): self |
There was a problem hiding this comment.
what about renaming this one to create instead? that would make the most sense to me as the current name is due to history - but this is a new component now
There was a problem hiding this comment.
But if somebody did use createFromThrowable which did also exist on the Debug FlattenException it will get there an error. I think in 4.4 we still should provide both functions.
|
I don't see how this help at all regarding BC. If you want to migrate from one FlattenException to the other one, you have to change the class name used for the static call, not only the name of the method. Using the same method name in both cases will not remove the need for a |
I'm currently trying to test 4.4-dev and did get over this issue when using FosRestBundle.
I also created a fix there but think this should not break in 4.4.
The old FlattenException did implement a
createfunction.