[DI] Add extra type check to php dumper #33958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Oct 12, 2019
|
Thank you @gquemener. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 12, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [DI] Add extra type check to php dumper | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #33942 | License | MIT | Doc PR This PR adds a missing type check in the PHP Dumper. The bug has been detected while working on the https://github.com/prooph/service-bus-symfony-bundle and I haven't been able to reproduce it within a minimalist testcase. I would like to add a unit test to cover it once I have figured out the exact context in which the bug occurs. Any help would be greatly appreciated to do so, especially from "senior" contributors of the DependencyInjection component, many thanks in advance! You will find more information about this bug in the linked ticket above. Commits ------- b17ebdf bug #33942 [DI] Add extra type check to php dumper
|
I've just realized that the I hope you have a simple way to fix this, let me know if I should re-open a PR against the correct branch. Sorry about that @nicolas-grekas ! |
|
4.2 is not maintained anymore, see https://symfony.com/releases |
Great! I missed this piece of information, thanks. Cheers 👋 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a missing type check in the PHP Dumper. The bug has been detected while working on the https://github.com/prooph/service-bus-symfony-bundle and I haven't been able to reproduce it within a minimalist testcase.
I would like to add a unit test to cover it once I have figured out the exact context in which the bug occurs.
Any help would be greatly appreciated to do so, especially from "senior" contributors of the DependencyInjection component, many thanks in advance!
You will find more information about this bug in the linked ticket above.