[HttpClient] try using php-http/discovery when nyholm/psr7 is not installed #33980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Oct 14, 2019
Nyholm
approved these changes
Oct 14, 2019
There was a problem hiding this comment.
You may want to catch an exception whenever you are using the PSR17Discovery class. That will allow you to customise the exception message a little.
Not sure if it is needed. We have documented the errors here: http://docs.php-http.org/en/latest/discovery.html#common-errors
nicolas-grekas
added a commit
that referenced
this pull request
Oct 14, 2019
…psr7 is not installed (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] try using php-http/discovery when nyholm/psr7 is not installed | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - In case one has `php-http/discovery`, we can leverage it... Commits ------- 6e0cb58 [HttpClient] try using php-http/discovery when nyholm/psr7 is not installed
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case one has
php-http/discovery, we can leverage it...