[Mailer] Fix Mandrill Transport API payload for named addresses #33994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Oct 16, 2019
|
Thank you @michaelperrin. |
fabpot
added a commit
that referenced
this pull request
Oct 16, 2019
…esses (Michaël Perrin) This PR was merged into the 4.3 branch. Discussion ---------- [Mailer] Fix Mandrill Transport API payload for named addresses | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #33993 <!-- prefix each issue number with "Fix #", if any --> | License | MIT Fix the Mandrill transport API payload when using named addressed. Fixes #33993 . I will make an other PR for branch 4.4 that includes tests on the payload as well (tests on mailing transports were introduced in 4.4)? I can do this on Wednesday. Commits ------- 6dbac13 [Mailer] Fix Mandrill Transport API payload with named addresses
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Mandrill transport API payload when using named addressed. Fixes #33993 .
I will make an other PR for branch 4.4 that includes tests on the payload as well (tests on mailing transports were introduced in 4.4)? I can do this on Wednesday.