[Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor #34019
+57
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like reading |
|
As in: make getCsvOptions() return two extra variables ? |
|
I tried, but when it was time to update the test, I realized that getCsvOptions() returns a different set of variables in encode() v/s decode(). |
|
My proposed changes are done, but I don't know how to correct the failing AppVeyor... |
nicolas-grekas
approved these changes
Nov 28, 2019
|
Thank you @savedario. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 28, 2019
…in constructor (Dario Savella)
This PR was squashed before being merged into the 4.3 branch.
Discussion
----------
[Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| License | MIT
My first pull request...
The following code:
```
$data = <<<EOD
a,b
c,d
EOD;
$encoder = new CsvEncoder([CsvEncoder::NO_HEADERS_KEY=>true]);
var_dump($encoder->decode($data,'csv'));
```
produces:
```
array(2) {
'a' =>
string(1) "c"
'b' =>
string(1) "d"
}
```
instead of the expected:
```
array(2) {
[0] =>
array(2) {
[0] =>
string(1) "a"
[1] =>
string(1) "b"
}
[1] =>
array(2) {
[0] =>
string(1) "c"
[1] =>
string(1) "d"
}
}
```
Commits
-------
a0430f6 [Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor
This was referenced Dec 1, 2019
Merged
Merged
Merged
hultberg
pushed a commit
to hultberg/symfony
that referenced
this pull request
Sep 17, 2021
…n used in constructor (Dario Savella)
This PR was squashed before being merged into the 4.3 branch.
Discussion
----------
[Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| License | MIT
My first pull request...
The following code:
```
$data = <<<EOD
a,b
c,d
EOD;
$encoder = new CsvEncoder([CsvEncoder::NO_HEADERS_KEY=>true]);
var_dump($encoder->decode($data,'csv'));
```
produces:
```
array(2) {
'a' =>
string(1) "c"
'b' =>
string(1) "d"
}
```
instead of the expected:
```
array(2) {
[0] =>
array(2) {
[0] =>
string(1) "a"
[1] =>
string(1) "b"
}
[1] =>
array(2) {
[0] =>
string(1) "c"
[1] =>
string(1) "d"
}
}
```
Commits
-------
a0430f6 [Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first pull request...
The following code:
produces:
instead of the expected: