[Mailer][MailchimpBridge] Fix NamedAddress obsolete paths #34029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Oct 18, 2019
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Oct 18, 2019
…(ogizanagi) This PR was merged into the 4.4 branch. Discussion ---------- [Mailer][MailchimpBridge] Fix NamedAddress obsolete paths | Q | A | ------------- | --- | Branch? | 4.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | N/A <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | N/A As NamedAddress was removed in #33270 (4.4) and this bridge does require `symfony/mailer >= 4.4`. Commits ------- f14d082 [Mailer][MailchimpBridge] Fix NamedAddress obsolete paths
|
Does the mailchimp API work well with an empty string as name, or should we omit it in that case ? |
fabpot
added a commit
that referenced
this pull request
Oct 22, 2019
…y string (ogizanagi) This PR was merged into the 4.4 branch. Discussion ---------- [Mailer][MailchimpBridge] Don't send address names if empty string | Q | A | ------------- | --- | Branch? | 4.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | #34029 (comment) <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | N/A Commits ------- 197d123 [Mailer][MailchimpBridge] Don't send address names if empty string
symfony-splitter
pushed a commit
to symfony/mailer
that referenced
this pull request
Sep 28, 2021
…y string (ogizanagi) This PR was merged into the 4.4 branch. Discussion ---------- [Mailer][MailchimpBridge] Don't send address names if empty string | Q | A | ------------- | --- | Branch? | 4.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | symfony/symfony#34029 (comment) <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | N/A Commits ------- 197d1236ee [Mailer][MailchimpBridge] Don't send address names if empty string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As NamedAddress was removed in #33270 (4.4) and this bridge does require
symfony/mailer >= 4.4(which itself requiressymfony/mime >= 4.4).