Skip to content

[Lock] Add missing lock connection string in FrameworkExtension #34043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Oct 21, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
Deprecations? yes
Tickets -
License MIT
Doc PR TODO

This PR adds support to missing DSN in Lock component

framework:
  lock: sqlite:/tmp/db
  lock: mysql:host=localhost;dbname=test
  lock: zookeeper://localhost:2181

The PR also removes intermediate "internal" services .lock_connection.* in favor of factory StoreFactory::createStore. Which remove duplicate code.

This PR also deprecate unused services lock.store.* and lock.store.*.abstract

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
@nicolas-grekas
Copy link
Member

Thank you @jderusse.

nicolas-grekas added a commit that referenced this pull request Oct 29, 2019
…Extension (jderusse)

This PR was merged into the 4.4 branch.

Discussion
----------

[Lock] Add missing lock connection string in FrameworkExtension

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | yes
| Tickets       | -
| License       | MIT
| Doc PR        | TODO

This PR adds support to missing DSN in Lock component

```
framework:
  lock: sqlite:/tmp/db
  lock: mysql:host=localhost;dbname=test
  lock: zookeeper://localhost:2181
```

The PR also removes intermediate "internal" services `.lock_connection.*` in favor of factory `StoreFactory::createStore`. Which remove duplicate code.

This PR also deprecate unused services `lock.store.*` and  `lock.store.*.abstract`

Commits
-------

2db24cf Add missing lock connection string in FrameworkExtension
@nicolas-grekas nicolas-grekas merged commit 2db24cf into symfony:4.4 Oct 29, 2019
fabpot added a commit that referenced this pull request Oct 30, 2019
…e session handler with a DSN (nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpFoundation][FrameworkBundle] allow configuring the session handler with a DSN

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

```yaml
framework:
    session:
        handler_id: 'redis://localhost'
        handler_id: '%env(REDIS_URL)%'
        handler_id: '%env(DATABASE_URL)%'
        handler_id: 'file://%kernel.project_dir%/var/sessions'
```

etc.

the database connection is not shared with the ORM (don't mess with transactions.)
redis/memcached connections are shared between cache and session.
(as a reminder, cache and ORM share the db connection: we're ok with trashing the cache on a rollback)

Lock-related changes are a follow up of #34043.
(fabbot failure is false positive)

Commits
-------

de9c61f [HttpFoundation][FrameworkBundle] allow configuring the session handler with a DSN
nicolas-grekas added a commit that referenced this pull request Nov 7, 2019
…web)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[FrameworkBundle] Remove Lock deprecated services

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Remove deprecated services in #34043.

Commits
-------

a8e10cf [FrameworkBundle] Remove Lock deprecated services
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Nov 7, 2019
…web)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[FrameworkBundle] Remove Lock deprecated services

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Remove deprecated services in symfony/symfony#34043.

Commits
-------

a8e10cffbb [FrameworkBundle] Remove Lock deprecated services
This was referenced Nov 12, 2019
@jderusse jderusse deleted the lock-connection branch March 5, 2020 20:03
wouterj added a commit to symfony/symfony-docs that referenced this pull request Oct 4, 2020
This PR was submitted for the master branch but it was squashed and merged into the 4.4 branch instead.

Discussion
----------

Add a documentation page for lock in FW

This PR add a dedicated page to explain how to use Lock with FrameworkBundle

This PR slightly depends on symfony/symfony#34043 (PDO and Zookeeper DSN)

I should have pushed this PR years ago 😢  sorry about that...

Fixes: #12561

Commits
-------

8bf4f85 Add a documentation page for lock in FW
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants