Skip to content

[Debug] work around failing chdir() on Darwin #34091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2019
Merged

[Debug] work around failing chdir() on Darwin #34091

merged 1 commit into from
Nov 28, 2019

Conversation

mary2501
Copy link
Contributor

@mary2501 mary2501 commented Oct 23, 2019 •
edited
Loading

Q A
Branch? 4.3 for bug fixes
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix https://github.com/happybottoms/coverd/issues/15
License MIT
Doc PR symfony/symfony-docs#...

@mary2501
Copy link
Contributor Author

Link Issues: https://github.com/happybottoms/coverd/issues/15

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Oct 25, 2019
@mary2501 mary2501 force-pushed the 4.3 branch 2 times, most recently from ca5a2c1 to 239d63f Compare November 22, 2019 19:59
@nicolas-grekas nicolas-grekas changed the title manage Symfony Maker errors when creating entity [Debug] work around failing chdir() on Darwin Nov 28, 2019
@nicolas-grekas
Copy link
Member

Thank you @mary2501.

nicolas-grekas added a commit that referenced this pull request Nov 28, 2019
@nicolas-grekas
bug #34091 [Debug] work around failing chdir() on Darwin (mary2501)
789c863 
This PR was merged into the 4.3 branch.

Discussion
----------

[Debug] work around failing chdir() on Darwin

| Q             | A
| ------------- | ---
| Branch?       |  4.3 for bug fixes <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix https://github.com/happybottoms/coverd/issues/15 <!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

f40373e [Debug] work around failing chdir() on Darwin
@nicolas-grekas nicolas-grekas merged commit f40373e into symfony:4.3 Nov 28, 2019
This was referenced Dec 1, 2019
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus requested changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@mary2501 @nicolas-grekas @derrabus @carsonbot