[Cache] add DeflateMarshaller - remove phpredis compression #34133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b936204 to
9be6aa3
Compare
9be6aa3 to
452c863
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Oct 30, 2019
…ssion (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [Cache] add DeflateMarshaller - remove phpredis compression | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - phpredis compression doesn't play well with lua scripting as used in #33939 Let's remove it and provide a `DeflateMarshaller` instead. Ppl can use it via decoration: ```yaml services: Symfony\Component\Cache\Marshaller\DeflateMarshaller: decorates: cache.default_marshaller arguments: ['@symfony\Component\Cache\Marshaller\DeflateMarshaller.inner'] ``` It's not enabled by default because that might break pools that are shared between different apps. /cc @andrerom FYI Commits ------- 452c863 [Cache] add DeflateMarshaller - remove phpredis compression
This was referenced Nov 12, 2019
Merged
Merged
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Mar 5, 2021
…che (Nyholm) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Cache] Remove `compression` option from Redis and Memcache This option was removed in 4.4 because it didn't work. See symfony/symfony#34133 This will fix #15050 Commits ------- b11322c [Cache] Remove `compression` option from Redis and Memcache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phpredis compression doesn't play well with lua scripting as used in #33939
Let's remove it and provide a
DeflateMarshallerinstead.Ppl can use it via decoration:
It's not enabled by default because that might break pools that are shared between different apps.
/cc @andrerom FYI