[Security/Core] make NativePasswordEncoder use sodium to validate passwords when possible #34140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Oct 27, 2019
chalasr
reviewed
Oct 28, 2019
952a067 to
34a02ee
Compare
|
PR rebased on 4.3 |
34a02ee to
2f673ca
Compare
…swords when possible
2f673ca to
799a2ea
Compare
|
Thank you @nicolas-grekas. |
chalasr
added a commit
that referenced
this pull request
Oct 28, 2019
…alidate passwords when possible (nicolas-grekas) This PR was merged into the 4.3 branch. Discussion ---------- [Security/Core] make NativePasswordEncoder use sodium to validate passwords when possible | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - sodium implementations are always faster, let's use them when possible. This also allows validating argon2 passwords when bcrypt is configured as the main one, making migrations possible. Commits ------- 799a2ea [Security/Core] make NativePasswordEncoder use sodium to validate passwords when possible
Merged
stof
reviewed
Nov 4, 2019
| @@ -45,7 +45,7 @@ public function __construct(int $opsLimit = null, int $memLimit = null, int $cos | |||
| throw new \InvalidArgumentException('$cost must be in the range of 4-31.'); | |||
| } | |||
|
|
|||
| $this->algo = \defined('PASSWORD_ARGON2I') ? max(PASSWORD_DEFAULT, \defined('PASSWORD_ARGON2ID') ? PASSWORD_ARGON2ID : PASSWORD_ARGON2I) : PASSWORD_DEFAULT; | |||
| $this->algo = \defined('PASSWORD_ARGON2ID') ? PASSWORD_ARGON2ID : (\defined('PASSWORD_ARGON2I') ? PASSWORD_ARGON2I : PASSWORD_BCRYPT); | |||
There was a problem hiding this comment.
your plan initially was to always be at least as good as PASSWORD_DEFAULT, even if PHP upgrades it. Is this plan gone ?
There was a problem hiding this comment.
yes, the plan is gone: in 7.4, PASSWORD_DEFAULT === null and other PASSWORD_* consts are strings; this makes it too difficult to maintain the plan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sodium implementations are always faster, let's use them when possible. This also allows validating argon2 passwords when bcrypt is configured as the main one, making migrations possible.