Re-allow to use "tagged" in service definitions #34170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Oct 29, 2019
|
Thank you @dunglas. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 29, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Re-allow to use "tagged" in service definitions | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | n/a | License | MIT | Doc PR | n/a Re-allow to use `tagged` in 4.4 and 5.0. It makes it easier for bundles to support both Symfony 4.3- and Symfony 4.4+. Needed to make API Platform compatible with Symfony 5 (api-platform/core#3009) Commits ------- 7b7dc0d Re-allow to use "tagged" in service definitions
|
Hi. Will |
|
Well, we'll probably deprecate this in some 5.x release for removal in 6.0, when it will be fine for third-party bundles to have SF 4.4 LTS as their min version. |
This was referenced Nov 12, 2019
Merged
Merged
|
@nicolas-grekas The "tagged" function was missing for the "ContainerConfigurator". Maybe the time has come to deprecated it ? I can open a PR if it's ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-allow to use
taggedin 4.4 and 5.0. It makes it easier for bundles to support both Symfony 4.3- and Symfony 4.4+.Needed to make API Platform compatible with Symfony 5 (api-platform/core#3009)