Skip to content

[Messenger] WIP: refactoring #34182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Messenger] WIP: refactoring #34182

wants to merge 1 commit into from

Conversation

Tobion
Copy link
Contributor

@Tobion Tobion commented Oct 30, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #32077
License MIT
Doc PR

@Tobion Tobion requested a review from sroze as a code owner October 30, 2019 00:43
@Tobion Tobion added this to the 4.4 milestone Oct 30, 2019
Tobion
Tobion commented Oct 30, 2019
View reviewed changes
src/Symfony/Component/Messenger/EventListener/SendFailedMessageForRetryListener.php
private $logger;

/**
* @param RetryStrategyInterface[] $retryStrategies Retry strategies for each receiver
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outdated

Tobion
Tobion commented Oct 30, 2019
View reviewed changes
src/Symfony/Component/Messenger/EventListener/SendFailedMessageForRetryListener.php
++$retryCount;
$delay = $retryStrategy->getWaitingTime($envelope);
if (null !== $this->logger) {
$this->logger->error('Error thrown while handling message {class}. Dispatching for retry #{retryCount} using {delay} ms delay. Error: "{error}"', $context + ['retryCount' => $retryCount, 'delay' => $delay, 'error' => $throwable->getMessage(), 'exception' => $throwable]);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix $context

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dispatching -> sending

@Tobion Tobion closed this Oct 30, 2019
@Tobion
Copy link
Contributor Author

Tobion commented Oct 30, 2019

reopened in #34185

@nicolas-grekas nicolas-grekas deleted the messenger-refactoring branch October 30, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Messenger Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

[Messenger] refactoring to get rid of SendersLocatorInterface::getSenderByAlias
2 participants
@Tobion @carsonbot