[HttpKernel] Add kernel.error event to handle uncaught \Error #34232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f7bc72 to
60d0fc4
Compare
Tobion
reviewed
Nov 4, 2019
| @@ -66,7 +68,7 @@ public function handle(Request $request, $type = HttpKernelInterface::MASTER_REQ | |||
|
|
|||
| try { | |||
| return $this->handleRaw($request, $type); | |||
| } catch (\Exception $e) { | |||
| } catch (\Throwable $e) { | |||
There was a problem hiding this comment.
This is a bc break. If I use the HttpKernel standalone, throwable did not trigger the exception event. Now it does.
There was a problem hiding this comment.
We could change the $catch parameter of this method to allow for more fine-grained control over what should be caught.
There was a problem hiding this comment.
What about just having 2 channels, exception and error, and we hook the ExceptionListener on both events. Backward compatible and errors can still be handled in 4.4.
60d0fc4 to
aebe6d5
Compare
|
I'm proposing #34306 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
kernel.errorevent as suggested in #33065 (comment).Only the second commit should be reviewed here.