Skip to content

Update bootstrap_4_layout.html.twig #34278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2020
Merged

Update bootstrap_4_layout.html.twig #34278

merged 1 commit into from
Feb 4, 2020
+3 −1

Conversation

CoalaJoe
Copy link
Contributor

@CoalaJoe CoalaJoe commented Nov 7, 2019 •
edited
Loading

Add lang attribute to enable translating the "Browse" after text using SCSS variables.
Example:

$custom-file-text: (
        en: "Browse",
        de: "Auswählen"
);

https://github.com/twbs/bootstrap/blob/v4.3.1/scss/_variables.scss#L640

Q A
Branch? 4.4 for features
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #
License MIT
Doc PR symfony/symfony-docs#...

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Nov 7, 2019
@nicolas-grekas
Copy link
Member

Can you please have a look at failing tests?
Please also update the table in the description of your PR, we need them to be filled in to triage things.
Thanks.

@fabpot fabpot modified the milestones: 4.4, next Nov 9, 2019
@CoalaJoe
Copy link
Contributor Author

@nicolas-grekas Do you have an idea why the one travis pipline failes?

@fabpot
Copy link
Member

fabpot commented Jan 10, 2020

@CoalaJoe No worries about tests (as the failed one is not related to this PR). Could you add a test about this new feature?

@CoalaJoe
Copy link
Contributor Author

I am sorry. I do not know where to start nor what to do. Can someone give me a hand?

@fabpot fabpot changed the base branch from 4.4 to master February 4, 2020 14:31
@fabpot
Copy link
Member

fabpot commented Feb 4, 2020

Thank you @CoalaJoe.

@fabpot fabpot mentioned this pull request Feb 4, 2020
Closed
@fabpot fabpot closed this in fc20461 Feb 4, 2020
@fabpot fabpot merged commit b1b724f into symfony:master Feb 4, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed TwigBridge
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@CoalaJoe @nicolas-grekas @fabpot @ogizanagi @carsonbot