[Routing] revert the return type for UrlGeneratorInterface::generate to remove null #34299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Nov 8, 2019
fabpot
approved these changes
Nov 9, 2019
|
Thank you @shieldo. |
fabpot
added a commit
that referenced
this pull request
Nov 9, 2019
…ce::generate to remove null (shieldo) This PR was merged into the 3.4 branch. Discussion ---------- [Routing] revert the return type for UrlGeneratorInterface::generate to remove null …to remove null | Q | A | ------------- | --- | Branch? | 3.4 (only) | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT Bit of a casualty of commit tennis this: A change to add `null` here as an option for how `UrlGeneratorInterface::generate()` (rather than the concrete `UrlGenerator`) was merged in #28321, but then [reverted](90494c2) for the reason [that this could be seen as a BC break](#28321 (comment)), as the `null` return had not previously been documented (and is still not as part of the interface method docs). However, in a subsequent change (#33252) with a wider scope, this doc change was added _back_ in order to reflect the underlying implementation as a result of a PHPStorm plugin complaining. There's no indication though of what a `null` return here though would mean, and for the same reason as the first revert (that this should be seen as a BC break), I'd like to submit this to be reverted for the 3.4 branch. (In 4.4 the `null` has already been removed.) Having the interface indicating that this method can return `null` necessitates introducing a lot of actually redundant null checks in code that is covered by static analysis tools such as PHPStan. Commits ------- 9f853f3 [Routing] revert the return type for UrlGeneratorInterface::generate to remove null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to remove null
Bit of a casualty of commit tennis this:
A change to add
nullhere as an option for howUrlGeneratorInterface::generate()(rather than the concreteUrlGenerator) was merged in #28321, but then reverted for the reason that this could be seen as a BC break, as thenullreturn had not previously been documented (and is still not as part of the interface method docs).However, in a subsequent change (#33252) with a wider scope, this doc change was added back in order to reflect the underlying implementation as a result of a PHPStorm plugin complaining. There's no indication though of what a
nullreturn here though would mean, and for the same reason as the first revert (that this should be seen as a BC break), I'd like to submit this to be reverted for the 3.4 branch. (In 4.4 thenullhas already been removed.)Having the interface indicating that this method can return
nullnecessitates introducing a lot of actually redundant null checks in code that is covered by static analysis tools such as PHPStan.