[4.4] Disallow symfony/contracts v2 #34307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
requested changes
Nov 9, 2019
2f29d30 to
f2dc2d6
Compare
|
I've reverted to the metapackage. Travis is green, AppVeyor failure looks unrelated. |
nicolas-grekas
approved these changes
Nov 9, 2019
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 9, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [4.4] Disallow symfony/contracts v2 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Travis is red at the moment because unit tests on 4.4 are run against the incompatible event dispatcher contracts v2. https://travis-ci.org/symfony/symfony/jobs/609622341#L4719-L4725 ~~This PR proposes to switch to individual packages, so we can specifically disallow those incompatible contracts.~~ This PR pins the `symfony/contracts` package to v1.1 on `symfony/symfony`. Commits ------- f2dc2d6 Disallow symfony/contracts v2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis is red at the moment because unit tests on 4.4 are run against the incompatible event dispatcher contracts v2. https://travis-ci.org/symfony/symfony/jobs/609622341#L4719-L4725
This PR proposes to switch to individual packages, so we can specifically disallow those incompatible contracts.This PR pins the
symfony/contractspackage to v1.1 onsymfony/symfony.