[HttpKernel] make ExceptionEvent able to propagate any throwable #34309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ee8468 to
956e9d0
Compare
956e9d0 to
6f67f0e
Compare
fabpot
approved these changes
Nov 10, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 10, 2019
… throwable (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] make ExceptionEvent able to propagate any throwable | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | - | License | MIT | Doc PR | - An alternative to #34306. As a reminder, the goal of this series of PRs is to remove the `FatalThrowableError` wrapper that we introduced to seamlessly handle throwables when they were introduced in PHP 7. From the changelog of `HttpKernel`: * Deprecated methods `ExceptionEvent::get/setException()`, use `get/setThrowable()` instead * Deprecated class `ExceptionListener`, use `ErrorListener` instead And the final target: removed `Symfony\Component\ErrorHandler\Exception\ErrorException` (`FatalThrowableError` is already deprecated.) Commits ------- 6f67f0e [HttpKernel] make ExceptionEvent able to propagate any throwable
xabbuh
added a commit
that referenced
this pull request
Nov 11, 2019
…bbuh) This PR was merged into the 5.0-dev branch. Discussion ---------- [Security] make ExceptionEvent handle all throwables | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | fixes `master` after merging #34309 up Commits ------- eba2d8e make ExceptionEvent handle all throwables
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #34306.
As a reminder, the goal of this series of PRs is to remove the
FatalThrowableErrorwrapper that we introduced to seamlessly handle throwables when they were introduced in PHP 7.From the changelog of
HttpKernel:ExceptionEvent::get/setException(), useget/setThrowable()insteadExceptionListener, useErrorListenerinsteadAnd the final target: removed
Symfony\Component\ErrorHandler\Exception\ErrorException(FatalThrowableErroris already deprecated.)