Skip to content

[Yaml] Added yaml-lint binary #34387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2020
Merged

[Yaml] Added yaml-lint binary #34387

merged 1 commit into from
Jan 11, 2020

Conversation

jschaedl
Copy link
Contributor

@jschaedl jschaedl commented Nov 15, 2019 •
edited by yceruto
Loading

Q A
Branch? 5.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #18987
License MIT
Doc PR tbd.

@jschaedl jschaedl requested a review from xabbuh as a code owner November 15, 2019 09:12
@xabbuh xabbuh added this to the next milestone Nov 15, 2019
@jschaedl jschaedl force-pushed the issue-18987 branch 2 times, most recently from 252dcff to 38cec58 Compare November 25, 2019 08:29
@jschaedl
Copy link
Contributor Author

jschaedl commented Nov 29, 2019 •
edited
Loading

Hi @xabbuh, ready to be merged, I guess? :-)

HeahDude
HeahDude reviewed Nov 29, 2019
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that PR!

@jschaedl
Copy link
Contributor Author

jschaedl commented Jan 7, 2020 •
edited
Loading

Looks like the failing tests are not related. So this PR is ready to be merged imho.

@jschaedl jschaedl requested review from stof and xabbuh January 10, 2020 16:46
@fabpot
Copy link
Member

fabpot commented Jan 11, 2020

Thank you @jschaedl.

@fabpot fabpot mentioned this pull request Jan 11, 2020
Closed
fabpot added a commit that referenced this pull request Jan 11, 2020
@fabpot
feature #34387 [Yaml] Added yaml-lint binary (jschaedl)
584b29d 
This PR was merged into the 5.1-dev branch.

Discussion
----------

[Yaml] Added yaml-lint binary

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #18987  <!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        | tbd.
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

2640dfe [Yaml] Introduce yaml-lint binary
@fabpot fabpot merged commit 2640dfe into symfony:master Jan 11, 2020
@jschaedl jschaedl deleted the issue-18987 branch February 23, 2020 08:03
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr left review comments

@HeahDude HeahDude HeahDude left review comments

@fabpot fabpot fabpot approved these changes

@derrabus derrabus derrabus approved these changes

@xabbuh xabbuh xabbuh approved these changes

@stof stof Awaiting requested review from stof

Assignees
No one assigned
Labels
Feature Status: Reviewed Yaml
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

lint:yaml command as a separated package
9 participants
@jschaedl @fabpot @stof @derrabus @xabbuh @chalasr @HeahDude @nicolas-grekas @carsonbot