[Cache] Redis Tag Aware warn on wrong eviction policy #34403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
09972f9 to
304ea8d
Compare
nicolas-grekas
approved these changes
Nov 16, 2019
304ea8d to
e77f6de
Compare
|
Thank you @andrerom. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 16, 2019
…rerom) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Cache] Redis Tag Aware warn on wrong eviction policy | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | Deprecations? | no | Tickets | n.a. | License | MIT | Doc PR | n.a. Adds validation to make sure Redis has been setup with the supported eviction policy to avoid surprises when cache suddenly is inconsistent. This PR replaces #34178, and instead of checking in constructor and throwing it only checks on save, warns about this and refuses to save cache as suggested on the other PR. TODO: - [x] ~Adapt test setups for this to set correct eviction policy~ _It already uses default noeviction_ Commits ------- e77f6de [Cache] Redis Tag Aware warn on wrong eviction policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation to make sure Redis has been setup with the supported eviction policy to avoid surprises when cache suddenly is inconsistent.
This PR replaces #34178, and instead of checking in constructor and throwing it only checks on save, warns about this and refuses to save cache as suggested on the other PR.
TODO:
Adapt test setups for this to set correct eviction policyIt already uses default noeviction