Skip to content

[Validator] remove return type declaration from __sleep() #34513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2019
Merged

[Validator] remove return type declaration from __sleep() #34513

merged 1 commit into from
Nov 24, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 22, 2019

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #34478
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.4 milestone Nov 22, 2019
@xabbuh xabbuh mentioned this pull request Nov 22, 2019
Closed
@greg0ire greg0ire mentioned this pull request Nov 24, 2019
Closed
@fabpot
Copy link
Member

fabpot commented Nov 24, 2019

Thank you @xabbuh.

fabpot added a commit that referenced this pull request Nov 24, 2019
@fabpot
bug #34513 [Validator] remove return type declaration from __sleep() …
e757512 
…(xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

[Validator] remove return type declaration from __sleep()

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34478
| License       | MIT
| Doc PR        |

Commits
-------

bedad35 remove return type declaration from __sleep()
@fabpot fabpot merged commit bedad35 into symfony:4.4 Nov 24, 2019
@xabbuh xabbuh deleted the issue-34478 branch November 24, 2019 20:08
@ureimers
Copy link
Contributor

ureimers commented Nov 25, 2019 •
edited
Loading

Hi,
thanks for the quick fix. But it seems to only be in the 4.4 branch (https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Validator/Constraint.php) but not in the 4.4 tag (https://github.com/symfony/symfony/blob/v4.4.0/src/Symfony/Component/Validator/Constraint.php). So composer update currently doesn't load it (as it's versioning is based on tags and not on branches, when not explicitly using the dev-* prefix).
Could you update/move the 4.4 tag as well please?

Thanks in advance and best regards,

Ulf

@xabbuh
Copy link
Member Author

xabbuh commented Nov 25, 2019

This will be part of the next patch (once published it will be 4.4.1). If you need it right now, you can require ^4.4@dev.

@ureimers
Copy link
Contributor

Ah, I see. I got it wrong, indeed this should be part of the next patch and not silently be merged into v4.4.

We reverted back to 4.3 for the moment as there's no operational need to switch to 4.4.

Thank you

This was referenced Dec 1, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dmaicher dmaicher dmaicher approved these changes

@ogizanagi ogizanagi ogizanagi approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed Validator
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@xabbuh @fabpot @ureimers @dmaicher @ogizanagi @carsonbot