[Monolog Bridge] Fixed accessing static property as non static. #34533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Sander-Toonen
commented
Nov 22, 2019
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #34505 |
| License | MIT |
| Doc PR | N/A |
xabbuh
requested changes
Nov 23, 2019
There was a problem hiding this comment.
The commit that changed the property to static (Seldaek/monolog@e0d18f4) was first released in Monolog 1.4.0. I think we should bump the requirement for monolog/monolog in composer.json accordingly.
|
Isn't the requirement for 4.4 requires ^1.25.1, 4.3 and 3.4 require ~1.19. |
xabbuh
approved these changes
Nov 23, 2019
xabbuh
approved these changes
Nov 23, 2019
fabpot
approved these changes
Nov 24, 2019
|
So, this one should be merged in 3.4, right? |
|
Thank you @Sander-Toonen. |
fabpot
added a commit
that referenced
this pull request
Nov 24, 2019
…atic. (Sander-Toonen) This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead (closes #34533). Discussion ---------- [Monolog Bridge] Fixed accessing static property as non static. | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34505 | License | MIT | Doc PR | N/A Commits ------- aa045d1 [Monolog Bridge] Fixed accessing static property as non static.
This was referenced Dec 1, 2019
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.