[Notifier] Add telegram tests #34539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeroeny
commented
Nov 23, 2019
src/Symfony/Component/Notifier/Bridge/Telegram/TelegramTransport.php
Outdated
Show resolved
Hide resolved
Jeroeny
commented
Nov 23, 2019
| @@ -20,6 +20,9 @@ | |||
| "symfony/http-client": "^4.3|^5.0", | |||
| "symfony/notifier": "~5.0.0" | |||
| }, | |||
| "require-dev": { | |||
| "symfony/event-dispatcher": "^4.3|^5.0" | |||
There was a problem hiding this comment.
Added because the AbstractTransport uses it in it's constructor. Not sure if it should actually be in require?
|
maybe we should add a test to ensure channel is optional? not sure if it fits better in factory or transport test 🤔 |
fabpot
approved these changes
Nov 30, 2019
94a627d to
3b4d83c
Compare
|
Thank you @Jeroeny. |
fabpot
added a commit
that referenced
this pull request
Nov 30, 2019
This PR was squashed before being merged into the 5.0 branch (closes #34539). Discussion ---------- [Notifier] Add telegram tests | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | See #33687 | License | MIT Adds tests for the Telegram bridge of the Notifier component. Not sure if this is the right way to go, but would love some feedback. #SymfonyHackday Commits ------- 3b4d83c [Notifier] Add telegram tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for the Telegram bridge of the Notifier component. Not sure if this is the right way to go, but would love some feedback.
#SymfonyHackday