-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Serializer] Add DateTimeZoneNormalizer into Dependency Injection #34546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
617e449
to
27ae785
Compare
Appveyor CI fail is not related to this PR |
Shouldn't this target 4.4? |
If we treat this as a bugfix, it must be merged into the |
nicolas-grekas
approved these changes
Nov 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.3 LGTM
fabpot
approved these changes
Nov 24, 2019
27ae785
to
1a81dd7
Compare
Thank you @jewome62. |
fabpot
added a commit
that referenced
this pull request
Nov 24, 2019
…jection (jewome62) This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes #34546). Discussion ---------- [Serializer] Add DateTimeZoneNormalizer into Dependency Injection | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | none | License | MIT | Doc PR | none #30915 I have forgot to add new Normalizer into DI 🤭 #SymfonyHackday Commits ------- 1a81dd7 Add DateTimeZoneNormalizer into Dependency Injection
This was referenced Dec 1, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#30915
I have forgot to add new Normalizer into DI 🤭
#SymfonyHackday