Added access decision strategy to respect voter priority #34548
Conversation
src/Symfony/Component/Security/Core/Authorization/AccessDecisionManager.php
Outdated
Show resolved
Hide resolved
|
regarding if/elseif, I just implemented it the same way the other strategies are implemented 🤷♂😊 let me know if I should change it. Sorry I don't understand what you're referring to with the |
have a look at deps=low failures ;) |
only AccessDecisionManager does it this way, and honeslty the switch looks less readable than some early return statements to me... |
Should I change the other statements too then? |
On branch 3.4 then, as all CS changes (to reduce future merge conflicts). |
|
now that I see it, it really looks much better 👍 |
This PR was merged into the 3.4 branch. Discussion ---------- CS for AccessDecisionManager | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #34548 | License | MIT | Doc PR | - As discussed in #34548 with @nicolas-grekas here's a CS change for the `AccessDecisionManager` Commits ------- b3742ec CS
|
@aschempp Can you add an entry to security and security-bundle CHANGELOG files? |
|
Updated in 0c78239. Let me know if that makes sense, I never did CHANGELOG files before 🙃 |
0c78239 to
0b8028a
Compare
|
Thank you @aschempp. |
The priority-based access decision strategy will decide based on the first voter that does not abstain from the decision. Security voters can be registered with priority (
PriorityTaggedServiceTrait), so a voter with higher priority can overrule other voters.In Contao CMS, the core system should provide security voters that provide the "default permissions", but extensions/bundles can override almost anything and therefore need to be able to override the core decision. None of the existing strategies allow for something like that.
/ping @chalasr @Toflar @leofeyer @ausi
#SymfonyHackday