Skip to content

[HttpClient] Fix early cleanup of pushed HTTP/2 responses #34554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2019
Merged

[HttpClient] Fix early cleanup of pushed HTTP/2 responses #34554

merged 1 commit into from
Nov 26, 2019

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Nov 23, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Nov 24, 2019
@lyrixx lyrixx force-pushed the http-client-funk-disco-test branch from 5fdf55b to 3a7a330 Compare November 24, 2019 19:34
@lyrixx lyrixx force-pushed the http-client-funk-disco-test branch from 3a7a330 to f5467ad Compare November 24, 2019 19:47
@lyrixx lyrixx changed the title [HttpClient] Added more functionnal tests [HttpClient] Added more functionnal tests + HttpClient implements ResetableInterface() + Fixed issue with dropping pushed response to soon Nov 24, 2019
@nicolas-grekas nicolas-grekas changed the title [HttpClient] Added more functionnal tests + HttpClient implements ResetableInterface() + Fixed issue with dropping pushed response to soon [HttpClient] Fix early cleanup of pushed HTTP/2 responses Nov 25, 2019
@nicolas-grekas nicolas-grekas force-pushed the http-client-funk-disco-test branch 4 times, most recently from d3c4076 to df4eac0 Compare November 25, 2019 12:34
@nicolas-grekas
Copy link
Member

@lyrixx I force-pushed the fix on your fork, tests are green - can you please check if the PR is good to you?
@dunglas maybe also since you were the first to spot the issue?

@nicolas-grekas nicolas-grekas force-pushed the http-client-funk-disco-test branch from df4eac0 to 0f51da6 Compare November 25, 2019 12:42
lyrixx
lyrixx commented Nov 25, 2019
View reviewed changes
Copy link
Member Author

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolas-grekas I can not approve my own pull request, but I'm 👍 with your work. Thank for finish it

@nicolas-grekas
Copy link
Member

Thank you @lyrixx.

nicolas-grekas added a commit that referenced this pull request Nov 26, 2019
@nicolas-grekas
bug #34554 [HttpClient] Fix early cleanup of pushed HTTP/2 responses …
59b6cfe 
…(lyrixx)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] Fix early cleanup of pushed HTTP/2 responses

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

0f51da6 [HttpClient] Fix early cleanup of pushed HTTP/2 responses
@nicolas-grekas nicolas-grekas merged commit 0f51da6 into symfony:4.4 Nov 26, 2019
@lyrixx lyrixx deleted the http-client-funk-disco-test branch November 26, 2019 10:17
nicolas-grekas added a commit that referenced this pull request Nov 28, 2019
@nicolas-grekas
bug #34554 [HttpClient] Fix early cleanup of pushed HTTP/2 responses …
53127c5 
…(lyrixx)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] Fix early cleanup of pushed HTTP/2 responses

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

0f51da6 [HttpClient] Fix early cleanup of pushed HTTP/2 responses
nicolas-grekas added a commit that referenced this pull request Nov 28, 2019
@nicolas-grekas
Merge branch '4.3' into 4.4
475967c 
* 4.3:
  bug #34554 [HttpClient] Fix early cleanup of pushed HTTP/2 responses (lyrixx)
nicolas-grekas added a commit that referenced this pull request Nov 28, 2019
@nicolas-grekas
Merge branch '4.4' into 5.0
3aa2a77 
* 4.4: (28 commits)
  bug #34554 [HttpClient] Fix early cleanup of pushed HTTP/2 responses (lyrixx)
  Fix tests
  [Console] Fix commands description with numeric namespaces
  [HttpFoundation] Fixed typo
  [DI] Skip unknown method calls for factories in check types pass
  [EventDispatcher] Better error reporting when arguments to dispatch() are swapped
  improve upgrade instructions for twig.exception_controller configuration
  [HttpFoundation] Update CHANGELOG for PdoSessionHandler BC BREAK in 4.4
  [Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor
  [Form] Keep preferred_choices order for choice groups
  [Debug] work around failing chdir() on Darwin
  [PhpUnitBridge] Read configuration CLI directive
  [DI] Missing test on YamlFileLoader
  Revert "minor #34608 [Process] add tests for php executable finder if file does not exist (ahmedash95)"
  Simpler example for Apache basic auth workaround
  [Console] Fix trying to access array offset on value of type int
  [Config] Remove extra sprintf arg
  [HttpKernel] fix typo
  [HttpKernel] Support typehint to deprecated FlattenException in controller
  Add preview mode support for Html and Serializer error renderers
  ...
nicolas-grekas added a commit that referenced this pull request Nov 28, 2019
@nicolas-grekas
Merge branch '5.0'
d7cc01c 
* 5.0: (30 commits)
  bug #34554 [HttpClient] Fix early cleanup of pushed HTTP/2 responses (lyrixx)
  Fix tests
  [Console] Fix commands description with numeric namespaces
  [HttpFoundation] Fixed typo
  [DI] Skip unknown method calls for factories in check types pass
  [EventDispatcher] Better error reporting when arguments to dispatch() are swapped
  [errorHandler] Remove old references from the old debug component
  improve upgrade instructions for twig.exception_controller configuration
  [HttpFoundation] Update CHANGELOG for PdoSessionHandler BC BREAK in 4.4
  [Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor
  [Form] Keep preferred_choices order for choice groups
  [Debug] work around failing chdir() on Darwin
  [PhpUnitBridge] Read configuration CLI directive
  [DI] Missing test on YamlFileLoader
  Revert "minor #34608 [Process] add tests for php executable finder if file does not exist (ahmedash95)"
  Simpler example for Apache basic auth workaround
  [Console] Fix trying to access array offset on value of type int
  [Config] Remove extra sprintf arg
  [HttpKernel] fix typo
  [HttpKernel] Support typehint to deprecated FlattenException in controller
  ...
This was referenced Dec 1, 2019
Merged
Merged
hultberg pushed a commit to hultberg/symfony that referenced this pull request Sep 17, 2021
@nicolas-grekas
Merge branch '4.4' into 5.0
d10bcdc 
* 4.4: (28 commits)
  bug symfony#34554 [HttpClient] Fix early cleanup of pushed HTTP/2 responses (lyrixx)
  Fix tests
  [Console] Fix commands description with numeric namespaces
  [HttpFoundation] Fixed typo
  [DI] Skip unknown method calls for factories in check types pass
  [EventDispatcher] Better error reporting when arguments to dispatch() are swapped
  improve upgrade instructions for twig.exception_controller configuration
  [HttpFoundation] Update CHANGELOG for PdoSessionHandler BC BREAK in 4.4
  [Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor
  [Form] Keep preferred_choices order for choice groups
  [Debug] work around failing chdir() on Darwin
  [PhpUnitBridge] Read configuration CLI directive
  [DI] Missing test on YamlFileLoader
  Revert "minor symfony#34608 [Process] add tests for php executable finder if file does not exist (ahmedash95)"
  Simpler example for Apache basic auth workaround
  [Console] Fix trying to access array offset on value of type int
  [Config] Remove extra sprintf arg
  [HttpKernel] fix typo
  [HttpKernel] Support typehint to deprecated FlattenException in controller
  Add preview mode support for Html and Serializer error renderers
  ...
hultberg pushed a commit to hultberg/symfony that referenced this pull request Sep 17, 2021
@nicolas-grekas
Merge branch '5.0'
05d1ae6 
* 5.0: (30 commits)
  bug symfony#34554 [HttpClient] Fix early cleanup of pushed HTTP/2 responses (lyrixx)
  Fix tests
  [Console] Fix commands description with numeric namespaces
  [HttpFoundation] Fixed typo
  [DI] Skip unknown method calls for factories in check types pass
  [EventDispatcher] Better error reporting when arguments to dispatch() are swapped
  [errorHandler] Remove old references from the old debug component
  improve upgrade instructions for twig.exception_controller configuration
  [HttpFoundation] Update CHANGELOG for PdoSessionHandler BC BREAK in 4.4
  [Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor
  [Form] Keep preferred_choices order for choice groups
  [Debug] work around failing chdir() on Darwin
  [PhpUnitBridge] Read configuration CLI directive
  [DI] Missing test on YamlFileLoader
  Revert "minor symfony#34608 [Process] add tests for php executable finder if file does not exist (ahmedash95)"
  Simpler example for Apache basic auth workaround
  [Console] Fix trying to access array offset on value of type int
  [Config] Remove extra sprintf arg
  [HttpKernel] fix typo
  [HttpKernel] Support typehint to deprecated FlattenException in controller
  ...
PhilETaylor pushed a commit to PhilETaylor/symfony that referenced this pull request Sep 6, 2023
@nicolas-grekas
Merge branch '4.4' into 5.0
9befa59 
* 4.4: (28 commits)
  bug symfony#34554 [HttpClient] Fix early cleanup of pushed HTTP/2 responses (lyrixx)
  Fix tests
  [Console] Fix commands description with numeric namespaces
  [HttpFoundation] Fixed typo
  [DI] Skip unknown method calls for factories in check types pass
  [EventDispatcher] Better error reporting when arguments to dispatch() are swapped
  improve upgrade instructions for twig.exception_controller configuration
  [HttpFoundation] Update CHANGELOG for PdoSessionHandler BC BREAK in 4.4
  [Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor
  [Form] Keep preferred_choices order for choice groups
  [Debug] work around failing chdir() on Darwin
  [PhpUnitBridge] Read configuration CLI directive
  [DI] Missing test on YamlFileLoader
  Revert "minor symfony#34608 [Process] add tests for php executable finder if file does not exist (ahmedash95)"
  Simpler example for Apache basic auth workaround
  [Console] Fix trying to access array offset on value of type int
  [Config] Remove extra sprintf arg
  [HttpKernel] fix typo
  [HttpKernel] Support typehint to deprecated FlattenException in controller
  Add preview mode support for Html and Serializer error renderers
  ...
PhilETaylor pushed a commit to PhilETaylor/symfony that referenced this pull request Sep 6, 2023
@nicolas-grekas
Merge branch '5.0'
0e062d9 
* 5.0: (30 commits)
  bug symfony#34554 [HttpClient] Fix early cleanup of pushed HTTP/2 responses (lyrixx)
  Fix tests
  [Console] Fix commands description with numeric namespaces
  [HttpFoundation] Fixed typo
  [DI] Skip unknown method calls for factories in check types pass
  [EventDispatcher] Better error reporting when arguments to dispatch() are swapped
  [errorHandler] Remove old references from the old debug component
  improve upgrade instructions for twig.exception_controller configuration
  [HttpFoundation] Update CHANGELOG for PdoSessionHandler BC BREAK in 4.4
  [Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor
  [Form] Keep preferred_choices order for choice groups
  [Debug] work around failing chdir() on Darwin
  [PhpUnitBridge] Read configuration CLI directive
  [DI] Missing test on YamlFileLoader
  Revert "minor symfony#34608 [Process] add tests for php executable finder if file does not exist (ahmedash95)"
  Simpler example for Apache basic auth workaround
  [Console] Fix trying to access array offset on value of type int
  [Config] Remove extra sprintf arg
  [HttpKernel] fix typo
  [HttpKernel] Support typehint to deprecated FlattenException in controller
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
HttpClient Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@lyrixx @nicolas-grekas @dunglas @carsonbot