[FrameworkBundle][Notifier] Fixing notifier email definition without mailer #34570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Nov 24, 2019
|
Thank you @chr-hertel. |
fabpot
added a commit
that referenced
this pull request
Nov 24, 2019
…on without mailer (chr-hertel) This PR was merged into the 5.0 branch. Discussion ---------- [FrameworkBundle][Notifier] Fixing notifier email definition without mailer | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | I ran into this while having notifier and messenger but no mailer installed. definition `notifier.channel.email` gets removed in line 1934 if mailer is not enabled so we can't replace the argument. ``` In ContainerBuilder.php line 980: You have requested a non-existent service "notifier.channel.email". ``` Commits ------- f12b0c7 only replace argument if mailer is present
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this while having notifier and messenger but no mailer installed. definition
notifier.channel.emailgets removed in line 1934 if mailer is not enabled so we can't replace the argument.