[HttpKernel] Don't cache "not-fresh" state #34580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Nov 25, 2019
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #34567 |
| License | MIT |
| Doc PR | - |
|
It fixed the issue, thanks! |
|
I'd appreciate 4.4.1 could be tagged as soon as this patch is merged 🙏 |
acasademont
approved these changes
Nov 25, 2019
fabpot
approved these changes
Nov 25, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 25, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] Don't cache "not-fresh" state | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34567 | License | MIT | Doc PR | - Commits ------- be80db3 [HttpKernel] Don't cache "not-fresh" state
|
@nicolas-grekas shouldn't we also mark the cache as fresh after we rebuild it ? |
|
@stof I considered this but thought it was not needed - this would only save one extra freshness check - with little to no perf benefit. |
This was referenced Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.