[MonologBridge] Fix debug processor datetime type #34601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Target branch is now 3.4, and tests have been added. The bug is still present in the DebugHandler, which have been deprecated in 3.2, then deleted in 4.0. Should I fix it and add tests ? |
mRoca
commented
Nov 25, 2019
| return [ | ||
| [array_merge($record, ['datetime' => new \DateTime('2019-01-01T00:01:00+00:00')]), 1546300860], | ||
| [array_merge($record, ['datetime' => '2019-01-01T00:01:00+00:00']), 1546300860], | ||
| [array_merge($record, ['datetime' => 'foo']), false], |
There was a problem hiding this comment.
What should the timestamp field contain if datetime is not a valid value ? As the DebugProcessor is not called before other processors, the data can be corrupted.
There was a problem hiding this comment.
the original value could be the best
let's fix it then, branch 4.3 because 4.2 is not maintained anymore
I don't know, this looks good enough to me. |
nicolas-grekas
approved these changes
Nov 27, 2019
Arman-Hosseini
approved these changes
Dec 1, 2019
|
Thank you @mRoca. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 10, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [MonologBridge] Fix debug processor datetime type | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets |n/a | License | MIT | Doc PR | n/a This PR fixes an eventual `Call to a member function getTimestamp() on string` if any Processor transforms the `datetime` value, and uses the same record conditions as in the [ConsoleFormatter](https://github.com/symfony/monolog-bridge/blob/master/Formatter/ConsoleFormatter.php#L118 ) Commits ------- ffe3f10 [MonologBridge] Fix debug processor datetime type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an eventual
Call to a member function getTimestamp() on stringif any Processor transforms thedatetimevalue, and uses the same record conditions as in the ConsoleFormatter