[VarDumper] notice on potential undefined index #34636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the question is how it is possible to have these non-existent keys in the output of |
|
Also if it is possible, we should probably not just fallback to null here, it may have other impacts on this code path. |
src/Symfony/Component/VarDumper/Dumper/ContextProvider/SourceContextProvider.php
Outdated
Show resolved
Hide resolved
it is, PHP inserts virtual frames in a few cases (can't remember exactly which ones) |
|
I have been trying to reproduce the error today to provide more context but I haven't be able to reproduce it yet. |
nicolas-grekas
approved these changes
Nov 28, 2019
|
Thank you @sylvainmetayer. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 28, 2019
…tayer) This PR was squashed before being merged into the 4.3 branch. Discussion ---------- [VarDumper] notice on potential undefined index Fix the following issue that can happen (Drupal 8 project for context, with the [Twig vardumper](https://www.drupal.org/project/twig_vardumper) module) : ``` Notice: Undefined index: file in Symfony\Component\VarDumper\Dumper\ContextProvider\SourceContextProvider->getContext() (line 55 of /var/www/app/vendor/symfony/var-dumper/Dumper/ContextProvider/SourceContextProvider.php). ``` | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | None | License | MIT | Doc PR | N/A Commits ------- d4c34e0 [VarDumper] notice on potential undefined index
This was referenced Dec 1, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following issue that can happen (Drupal 8 project for context, with the Twig vardumper module) :