Skip to content

[Notifier] added Sinch texter transport #34654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2020
Merged

[Notifier] added Sinch texter transport #34654

merged 1 commit into from
Feb 17, 2020

Conversation

imiroslavov
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

This PR adds adapter for Sinch messaging gateway to the texter transport.

Example configuration:
sinch://SID:TOKEN@default?from=PHONE

@imiroslavov imiroslavov mentioned this pull request Nov 27, 2019
Closed
1 task
@imiroslavov imiroslavov force-pushed the feature/sinch-notifier branch 2 times, most recently from 70bdac8 to 1014673 Compare November 27, 2019 12:19
@nicolas-grekas nicolas-grekas added this to the next milestone Nov 27, 2019
@fabpot fabpot added the Notifier label Feb 4, 2020
@imiroslavov imiroslavov force-pushed the feature/sinch-notifier branch 2 times, most recently from aea1ad3 to 2cd326d Compare February 17, 2020 12:04
OskarStark
OskarStark approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@fabpot fabpot force-pushed the feature/sinch-notifier branch from 2cd326d to db6d360 Compare February 17, 2020 16:10
@fabpot
Copy link
Member

fabpot commented Feb 17, 2020

Thank you @imiroslavov.

fabpot added a commit that referenced this pull request Feb 17, 2020
@fabpot
feature #34654 [Notifier] added Sinch texter transport (imiroslavov)
2b68d53 
This PR was squashed before being merged into the 5.1-dev branch.

Discussion
----------

[Notifier] added Sinch texter transport

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

This PR adds adapter for Sinch messaging gateway to the texter transport.

Example configuration:
`sinch://SID:TOKEN@default?from=PHONE`

Commits
-------

db6d360 [Notifier] added Sinch texter transport
@fabpot fabpot mentioned this pull request Feb 17, 2020
Closed
@fabpot fabpot merged commit db6d360 into symfony:master Feb 17, 2020
@imiroslavov imiroslavov deleted the feature/sinch-notifier branch March 5, 2020 10:45
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@imiroslavov @fabpot @OskarStark @nicolas-grekas @carsonbot