[HttpKernel] Support typehint to deprecated FlattenException in controller #34662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Nov 27, 2019
yceruto
reviewed
Nov 27, 2019
nicolas-grekas
approved these changes
Nov 28, 2019
src/Symfony/Component/HttpKernel/EventListener/ErrorListener.php
Outdated
Show resolved
Hide resolved
|
My use case: |
84163e5 to
26b4e37
Compare
|
Thank you @andrew-demb. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 28, 2019
…on in controller (andrew-demb) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [HttpKernel] Support typehint to deprecated FlattenException in controller | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34661 | License | MIT | Doc PR | We should support converting throwable to `FlattenException` with typehint to deprecated class also Commits ------- 26b4e37 [HttpKernel] Support typehint to deprecated FlattenException in controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should support converting throwable to
FlattenExceptionwith typehint to deprecated class also