[EventDispatcher] Better error reporting when arguments to dispatch() are swapped #34677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
previously approved these changes
Nov 28, 2019
|
It looks like we broke a test case sorry. |
|
Should I revert to checking for actual classes then, or change tests instead? |
yes please |
src/Symfony/Component/EventDispatcher/LegacyEventDispatcherProxy.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Nov 28, 2019
|
Thanks for bearing with me! I can squash the commits if you like. |
|
Thank you @rimas-kudelis. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 28, 2019
… dispatch() are swapped (rimas-kudelis) This PR was squashed before being merged into the 4.3 branch. Discussion ---------- [EventDispatcher] Better error reporting when arguments to dispatch() are swapped | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34676 | License | MIT Incorrect error is currently being reported when the second argument is an instance of `Symfony\Contracts\EventDispatcher\Event`. Commits ------- 54aac56 [EventDispatcher] Better error reporting when arguments to dispatch() are swapped
This was referenced Dec 1, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrect error is currently being reported when the second argument is an instance of
Symfony\Contracts\EventDispatcher\Event.