[TwigBundle] remove service when base class is missing #34715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Nov 29, 2019
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
|
What's the context? Doesn't the container already remove the service? How did you spot this? |
|
Oups, this triggers a deprecation :) |
|
Here is an example: https://travis-ci.org/FriendsOfSymfony/FOSRestBundle/jobs/618583998#L305 |
2dea1da to
0d8863b
Compare
0d8863b to
86826c3
Compare
86826c3 to
c3a658a
Compare
nicolas-grekas
approved these changes
Nov 30, 2019
fabpot
approved these changes
Nov 30, 2019
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Nov 30, 2019
…bbuh) This PR was merged into the 4.4 branch. Discussion ---------- [TwigBundle] remove service when base class is missing | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- c3a658a remove service when base class is missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.