[MonologBridge] Add test on ServerLogHandler #34721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d134e41 to
247b977
Compare
|
that's for 4.3 yes |
247b977 to
8c7947f
Compare
|
Done |
|
Thank you @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 3, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [MonologBridge] Add test on ServerLogHandler | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | / | License | MIT | Doc PR | / After writing #34697 (comment) I realized that ServerLogHandler wasn't tested. Tell me if it's a BugFix and should be rebased on 4.3 Commits ------- 8c7947f Add test on ServerLogHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After writing #34697 (comment) I realized that ServerLogHandler wasn't tested.
Tell me if it's a BugFix and should be rebased on 4.3