[FrameworkBundle] resolve service locators in debug:* commands
#34755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darielopper
approved these changes
Dec 2, 2019
chalasr
approved these changes
Dec 2, 2019
|
Adding a doc comment or updating the command test case would be nice though :) |
This command has no test case, I'd prefer moving on here, this is a debug tool, nothing critical. |
|
Thank you @nicolas-grekas. |
chalasr
added a commit
that referenced
this pull request
Dec 6, 2019
…mmands (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] resolve service locators in `debug:*` commands | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34470 | License | MIT | Doc PR | - Because of the way ServiceClosureArgument are dumped, we need to resolve locators after loading the xml dump of the container: https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/DependencyInjection/Dumper/XmlDumper.php#L273 Commits ------- 820da66 [FrameworkBundle] resolve service locators in `debug:*` commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the way ServiceClosureArgument are dumped, we need to resolve locators after loading the xml dump of the container:
https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/DependencyInjection/Dumper/XmlDumper.php#L273