[Mailer] Fix SMTP Authentication when using STARTTLS #34760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to write a test covering this, to prevent regressions ? |
|
Yes off course @stof ! Can I use some fixed EHLO exchanges like the one above or should I connect to a real server? |
|
@DjLeChuck We tend to avoid connecting to real servers to have fast and stable tests. So, replaying a real scenario is best. |
|
I'm stuck, I don't know how to test without having to connect to a real server. I don't know well PHPUnit and I lose myself in the mocking system. If someone wants to take the problem or help me, you're welcome! |
fabpot
approved these changes
Dec 7, 2019
|
Thank you @DjLeChuck. |
fabpot
added a commit
that referenced
this pull request
Dec 7, 2019
…Chuck) This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] Fix SMTP Authentication when using STARTTLS | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34522 | License | MIT When the mail server uses STARTTLS, the SMTP Authentication is not performed because the AUTH capabilities are not send during the first EHLO call, but during the second one. Example of problematic exchange solved by this PR: ``` < 220 mydomain.tld ESMTP Postcow > EHLO [127.0.0.1] < 250-mydomain.tld < 250-PIPELINING < 250-SIZE 104857600 < 250-ETRN < 250-STARTTLS < 250-ENHANCEDSTATUSCODES < 250-8BITMIME < 250-DSN < 250 CHUNKING > STARTTLS < 220 2.0.0 Ready to start TLS > EHLO [127.0.0.1] < 250-mydomain.tld < 250-PIPELINING < 250-SIZE 104857600 < 250-ETRN < 250-AUTH PLAIN LOGIN < 250-AUTH=PLAIN LOGIN < 250-ENHANCEDSTATUSCODES < 250-8BITMIME < 250-DSN < 250 CHUNKING > MAIL FROM:<noreply@XXX> < 250 2.1.0 Ok > RCPT TO:<XXX> < 554 5.7.1 <XXX>: Client host rejected: Access denied ``` Commits ------- 75b5454 [Mailer] Fix SMTP Authentication when using STARTTLS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the mail server uses STARTTLS, the SMTP Authentication is not performed because the AUTH capabilities are not send during the first EHLO call, but during the second one.
Example of problematic exchange solved by this PR: