Deprecate *Response::create() methods #34771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db949ec to
ebb13e7
Compare
OskarStark
approved these changes
Dec 3, 2019
xabbuh
approved these changes
Dec 3, 2019
fabpot
added a commit
that referenced
this pull request
Dec 3, 2019
This PR was merged into the 5.1-dev branch. Discussion ---------- Deprecate *Response::create() methods | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | n/a<!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | - The `::create()` methods of the `Response` class hierarchy are not needed anymore in modern PHP versions as we can use parenthesis around the new operator. So `Response::create()->...()` is equivalent to `(new Response)->...()`. Let's deprecate the static method. It's also good as the first parameter type changes depending on the sub-class. Commits ------- ebb13e7 Deprecate *Response::create() methods
stof
reviewed
Dec 3, 2019
| HttpFoundation | ||
| -------------- | ||
|
|
||
| * Deprecate `Response::create()`, `JsonResponse::create()`, |
There was a problem hiding this comment.
should be Deprecated for consistency (all messages are using the past in the upgrade guide)
There was a problem hiding this comment.
I'm slowly moving to use more "modern" message patterns as use everywhere else.
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Dec 4, 2019
This PR was merged into the 4.3 branch. Discussion ---------- *Response::create() method is deprecated @fabpot deprecated `*Response::create()` methods in symfony/symfony#34771 I think we can use `__construct` from the lowest version on (no occurences in `3.4`, so `4.3`) from now! No need to mention the deprecation itself in the docs IMHO Thats why I target `4.3` Commits ------- e930ea9 *Response::create() method is deprecated
Merged
fabpot
added a commit
that referenced
this pull request
Nov 27, 2020
…) (derrabus) This PR was merged into the 5.2 branch. Discussion ---------- [HttpFoundation] Deprecate BinaryFileResponse::create() | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | N/A | License | MIT | Doc PR | N/A Follows #34771. We've deprecated the static `::create()` methods on all response classes but `BinaryFileResponse`. This PR proposes to fix this inconsistency. Commits ------- 9ce2e86 [HttpFoundation] Deprecate BinaryFileResponse::create().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
::create()methods of theResponseclass hierarchy are not needed anymore in modern PHP versions as we can use parenthesis around the new operator. SoResponse::create()->...()is equivalent to(new Response)->...().Let's deprecate the static method. It's also good as the first parameter type changes depending on the sub-class.