[3.4][Validator] Allow underscore character "_" in URL username and password #34832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Dec 5, 2019
javiereguiluz
approved these changes
Dec 5, 2019
There was a problem hiding this comment.
In the https://tools.ietf.org/html/rfc1738 they don't say anything about not allowing this.
Thus, only alphanumerics and the special characters "$-_.+!*'()," may
be used unencoded within a URL.
[...]
Within the user and password field, any ":", "@", or "/" must be encoded.
So, using _ looks like it's allowed in both the user and password.
Thanks Romain!
xabbuh
approved these changes
Dec 5, 2019
fabpot
approved these changes
Dec 5, 2019
|
Thank you @romainneutron. |
fabpot
added a commit
that referenced
this pull request
Dec 5, 2019
…rname and password (romainneutron) This PR was merged into the 3.4 branch. Discussion ---------- [3.4][Validator] Allow underscore character "_" in URL username and password | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT Hello! It's been a long time since my last push on Symfony :) Here's a bug fix. I think URL usernames and password may contain an underscore. Let me know! Commits ------- 869518b [Validator] Allow underscore character "_" in URL username and password
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
It's been a long time since my last push on Symfony :)
Here's a bug fix. I think URL usernames and password may contain an underscore. Let me know!