Revert "feature #32126 [Process] Allow writing portable "prepared" command lines (Simperfit)" #34845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2019
|
I think it's safe of me to assume that this will also get merged in 5.x? |
|
@driesvints absolutely: we merge lower branches into upper ones periodically. |
|
Alternatively we could find another set of delimiters, or a special prefix, etc. Anyone? |
|
I personally think it's best that this is reverted. I don't have too much experience of this component to know about an alternative solution. But anything really that would revert the breaking change is fine. |
If you really need this feature, IMHO would say that is your best option; a special prefix. |
|
Alternative posted in #34848 |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 10, 2019
…olas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [Process] change the syntax of portable command lines | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34838 | License | MIT | Doc PR | symfony/symfony-docs#12772 An alternative to #34845 Right now, portable command lines use `"$FOO"` for placeholders. But because we validate that a corresponding variable exists before running the command, this fails with `Command line is missing a value for key "$FOO"` when `FOO` is not defined. This PR proposes to use `"${:FOO}"` instead. The difference with the previous syntax is that this cannot collide with existing shell scripts as it is invalid for them. When this is merged, we'll have to update https://symfony.com/blog/new-in-symfony-4-1-prepared-commands too. Commits ------- 3c7b775 [Process] change the syntax of portable prepared command lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit bd8ad3f, reversing
changes made to f15722d.
This was my idea, and it happens it was a bad one - I totally missed this would break running actual shell scripts.
When this is merged, we'll have to update https://symfony.com/blog/new-in-symfony-4-1-prepared-commands too /cc @javiereguiluz