Add support for safe HTTP preference - RFC 8674 #34847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrech
commented
Dec 6, 2019
|
Is a default value of |
|
@cjunge I'm not sure to understand where this default value would be. Do you mean in the request or in the response? Anyway, from what I understand from the RFC:
There is no such thing as "prefering a not safe content" or sending a response with "preference not applied". |
|
Comments fixed and PR rebased 😉 |
nicolas-grekas
approved these changes
Dec 16, 2019
|
Oups, wait, tests fail. |
|
Oups, sorry, tests should be green now |
fabpot
approved these changes
Jan 10, 2020
|
Thank you @pyrech. |
fabpot
added a commit
that referenced
this pull request
Jan 10, 2020
This PR was merged into the 5.1-dev branch. Discussion ---------- Add support for safe HTTP preference - RFC 8674 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - [RFC 8674](https://tools.ietf.org/html/rfc8674) (not a IETF standard at the moment) defines a way for user agents to ask for "safe" content to a server. This PR add helper methods to : - know if the user agent prefers a safe content - mark the response as safe Commits ------- 7f2cef7 Add support for safe preference - RFC8674
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Feb 17, 2020
This PR was merged into the master branch. Discussion ---------- Add documentation for RFC 8674 support Add documentation for the PR symfony/symfony#34847 Fix #12915 Commits ------- 54d06f5 Add documentation for RFC 8674 support
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 8674 (not a IETF standard at the moment) defines a way for user agents to ask for "safe" content to a server. This PR add helper methods to :