[FrameworkBundle][ContainerLintCommand] Reinitialize bundles when the container is reprepared #34862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… container is reprepared
6d61e43 to
31975e4
Compare
nicolas-grekas
approved these changes
Dec 10, 2019
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 10, 2019
…es when the container is reprepared (fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle][ContainerLintCommand] Reinitialize bundles when the container is reprepared | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Some bundles extensions are "instances dependents", eg they cache service registrations (eg: https://github.com/symfony/symfony/blob/70dec3c8a39181dcf403fb54b92c065f55edfa3c/src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php#L743). Launching the lint command loads all bundles a first time, just to be able to run the command. Then, when we build the container again for the lint command, it loads all bundles a second time. But since it's the same bundles instances, some services are not registered, leading to missing services in `CheckExceptionOnInvalidReferenceBehaviorPass`. Commits ------- 31975e4 [FrameworkBundle][ContainerLintCommand] Reinitialize bundles when the container is reprepared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bundles extensions are "instances dependents", eg they cache service registrations (eg:
symfony/src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php
Line 743 in 70dec3c
Launching the lint command loads all bundles a first time, just to be able to run the command.
Then, when we build the container again for the lint command, it loads all bundles a second time. But since it's the same bundles instances, some services are not registered, leading to missing services in
CheckExceptionOnInvalidReferenceBehaviorPass.