[FrameworkBundle] Add info & example to auto_mapping config #34887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -855,6 +855,11 @@ private function addValidationSection(ArrayNodeDefinition $rootNode) | |||
| ->end() | |||
| ->end() | |||
| ->arrayNode('auto_mapping') | |||
| ->info('A collection of namespaces for which auto-mapping will be enabled.') | |||
There was a problem hiding this comment.
That's describing the keys - should we describe the values also?
There was a problem hiding this comment.
I changed this after @weaverryan 's suggestion in #34707 (comment) actually. Perhaps we can find something between, or just add info on the services node below.
nicolas-grekas
approved these changes
Dec 13, 2019
fabpot
approved these changes
Dec 15, 2019
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Dec 15, 2019
…fig (ogizanagi) This PR was merged into the 4.3 branch. Discussion ---------- [FrameworkBundle] Add info & example to auto_mapping config | Q | A | ------------- | --- | Branch? | 4.3 <!-- see below --> | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | N/A <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | N/A Backport part of #34707 and add example. Commits ------- 8eb29a7 [FrameworkBundle] Add info & example to auto_mapping config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport part of #34707 and add example.