[Cache] fix memory leak when using PhpFilesAdapter #34896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98ea7b1 to
c0af43c
Compare
c0af43c to
0b46226
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Dec 10, 2019
…s-grekas) This PR was merged into the 4.3 branch. Discussion ---------- [Cache] fix memory leak when using PhpFilesAdapter | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34687 | License | MIT | Doc PR | - Similar to #34839 but for `PhpFilesAdapter`, as the "appendOnly" mode is a v4-only feature. Commits ------- 0b46226 [Cache] fix memory leak when using PhpFilesAdapter
|
Any chance of a 4.3 release with this included? A 4.4 and 5.0 release was made with this, but not 4.3. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #34839 but for
PhpFilesAdapter, as the "appendOnly" mode is a v4-only feature.