[HttpFoundation] Removed "Content-Type" from the preferred format guessing mechanism #34921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 10, 2019
stof
reviewed
Dec 10, 2019
stof
approved these changes
Dec 10, 2019
fabpot
approved these changes
Dec 11, 2019
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Dec 11, 2019
… format guessing mechanism (yceruto) This PR was merged into the 4.4 branch. Discussion ---------- [HttpFoundation] Removed "Content-Type" from the preferred format guessing mechanism | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34906, Fix #34857 | License | MIT | Doc PR | - Confirmed, inferring the `Content-Type` of the response using the `Content-Type` provided for the request body is NOT a good idea. The HTTP RFC explicitly states that `Accept` must be used to hint a preferred response format (`Content-Type` on the request indicates the type of associated its the body). Use `Accept` if provided (a best practice anyway), and fallback to the default value (HTML by default) otherwise. Commits ------- 776523e Removed request header "Content-Type" from the preferred format guessing mechanism
dresh
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmed, inferring the
Content-Typeof the response using theContent-Typeprovided for the request body is NOT a good idea. The HTTP RFC explicitly states thatAcceptmust be used to hint a preferred response format (Content-Typeon the request indicates the type of associated its the body).Use
Acceptif provided (a best practice anyway), and fallback to the default value (HTML by default) otherwise.