Skip to content

[DI] Fix support for immutable setters in CallTrait #34923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2019
Merged

[DI] Fix support for immutable setters in CallTrait #34923

merged 1 commit into from
Dec 11, 2019

Conversation

Lctrs
Copy link
Contributor

@Lctrs Lctrs commented Dec 10, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR N/A

nicolas-grekas
nicolas-grekas approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 4.4 as a bug fix to me.

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Dec 10, 2019
@Lctrs
Copy link
Contributor Author

Lctrs commented Dec 10, 2019

Not in 4.3 ? This param has been introduced on this branch.

@nicolas-grekas nicolas-grekas modified the milestones: 4.4, 4.3 Dec 10, 2019
@nicolas-grekas
Copy link
Member

4.3 then, you're right!

@Lctrs Lctrs changed the base branch from master to 4.3 December 10, 2019 23:46
@Lctrs Lctrs closed this Dec 10, 2019
@Lctrs Lctrs reopened this Dec 10, 2019
@Lctrs
Copy link
Contributor Author

Lctrs commented Dec 10, 2019

@nicolas-grekas Done !

nicolas-grekas
nicolas-grekas reviewed Dec 11, 2019
View reviewed changes
src/Symfony/Component/DependencyInjection/Loader/Configurator/Traits/CallTrait.php Outdated
*
* @return $this
*
* @throws InvalidArgumentException on empty $method param
*/
final public function call($method, array $arguments = [])
final public function call($method, array $arguments = []/*, bool $returnsClone = false*/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the compat layer: the method is final, we can add the argument.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@nicolas-grekas nicolas-grekas changed the title [DI] Add support for immutable setters in CallTrait [DI] Fix support for immutable setters in CallTrait Dec 11, 2019
@nicolas-grekas
Copy link
Member

Thank you @Lctrs.

nicolas-grekas added a commit that referenced this pull request Dec 11, 2019
@nicolas-grekas
bug #34923 [DI] Fix support for immutable setters in CallTrait (Lctrs)
d294085 
This PR was merged into the 4.3 branch.

Discussion
----------

[DI] Fix support for immutable setters in CallTrait

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        | N/A

Commits
-------

90ace51 [DI] Add support for immutable setters in CallTrait
@nicolas-grekas nicolas-grekas merged commit 90ace51 into symfony:4.3 Dec 11, 2019
@Lctrs Lctrs deleted the immutable_in_call_trait branch December 11, 2019 12:27
This was referenced Dec 19, 2019
Merged
Merged
@fabpot fabpot mentioned this pull request Jan 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
DependencyInjection Feature Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Lctrs @nicolas-grekas @carsonbot