Skip to content

[HttpClient] Add stream_set_option method to StreamWrapper #34969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[HttpClient] Add stream_set_option method to StreamWrapper #34969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/Symfony/Component/HttpClient/Response/StreamWrapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,28 @@ public function stream_read(int $count)
return '';
}

public function stream_set_option(int $option, int $arg1, ?int $arg2): bool
{
if (null === $this->handle || 'stream' !== get_resource_type($this->handle)) {
trigger_error(sprintf('The "$handle" property of "%s" need to be a stream.', __CLASS__), E_USER_WARNING);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null handler cannot occur at this point (it is when the stream is not open but you cannot call that kind of function if you don't have an openned stream?!)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$handle is null when CurlHttpClient is used, as Nicolas commented :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/need/needs
but since the response is set in a property, I think it would be nicer to mention it
btw, how does PHP behave when we return false? does it throw another warning on its own?


return false;
}

switch ($option) {
case STREAM_OPTION_BLOCKING:
return \stream_set_blocking($this->handle, $arg1);
case STREAM_OPTION_READ_TIMEOUT:
return \stream_set_timeout($this->handle, $arg1, $arg2);
case STREAM_OPTION_WRITE_BUFFER:
return \stream_set_write_buffer($this->handle, $arg1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong CS, see fabbot

default:
trigger_error(sprintf('The option "%s" is unknown for "stream_set_option" method', $option), E_ERROR);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E_ERROR is not legal
but let's return false and remove the warning, this cannot happen in practice


return false;
}
}

public function stream_tell(): int
{
return $this->offset;
Expand Down