[Dotenv] FIX missing getenv #35022
Merged
[Dotenv] FIX missing getenv #35022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c96920f to
1fe3375
Compare
yes, on Apache. Command line and Unit tests work.
variables_order => GPCS => GPCS
Yes, on the Apache vHost I would need to set the missing env vars with |
1fe3375 to
e0673f9
Compare
e0673f9 to
9c5754a
Compare
nicolas-grekas
approved these changes
Dec 18, 2019
|
Thank you @mccullagh. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 18, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Dotenv] FIX missing getenv | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no> | Tickets | Fix #34598 | License | MIT | Doc PR | - Revert one line to use getenv because not all environment variables are populated in $_ENV[] Commits ------- 9c5754a [Dotenv] FIX missing getenv
nicolas-grekas
added a commit
that referenced
this pull request
Dec 26, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Fixed test added in #35022 | Q | A | ------------- | --- | Branch? | master for features / 3.4, 4.3, 4.4 or 5.0 for bug fixes <!-- see below --> | Bug fix? | yes/no | New feature? | yes/no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | yes/no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #... <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch master. --> Commits ------- 6eeec7c Fixed test added in #35022
nicolas-grekas
added a commit
that referenced
this pull request
Dec 28, 2019
* 3.4:
Add missing use statement
[Profiler] wording
X-Accel Nginx URL updated
ticket-30197 [Validator] Add the missing translations for the Chinese (Taiwan) ("zh_TW") locale
Fixed test added in #35022
Use locale_parse for computing fallback locales
[Console] Fix filtering out identical alternatives when there is a command loader
nicolas-grekas
added a commit
that referenced
this pull request
Dec 28, 2019
* 4.3: Fixed #35084 Add missing use statement [HttpClient] fix scheduling pending NativeResponse do not overwrite variable value [Profiler] wording Use spaces correctly to display options in DebugCommand X-Accel Nginx URL updated ticket-30197 [Validator] Add the missing translations for the Chinese (Taiwan) ("zh_TW") locale Fixed test added in #35022 Use locale_parse for computing fallback locales [Console] Fix filtering out identical alternatives when there is a command loader
nicolas-grekas
added a commit
that referenced
this pull request
Dec 28, 2019
* 5.0: (24 commits) Removing unused variable Fixed #35084 Add missing use statement [HttpClient] fix scheduling pending NativeResponse do not overwrite variable value [Profiler] wording Use spaces correctly to display options in DebugCommand Add supported schemes doc blocks type X-Accel Nginx URL updated ticket-30197 [Validator] Add the missing translations for the Chinese (Taiwan) ("zh_TW") locale Fixed test added in #35022 Use locale_parse for computing fallback locales [Console] Fix filtering out identical alternatives when there is a command loader [String][UnicodeString] Remove unneeded flag in chunk regex pattern add note about HTTP status code change Migrate server:log command away from WebServerBundle [DependencyInjection][CheckTypeDeclarationsPass] Handle \Closure for callable [Security] Fix missing defaults for auto-migrating encoders bumped Symfony version to 5.0.3 updated VERSION for 5.0.2 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert one line to use getenv because not all environment variables are populated in $_ENV[]