[String] Add the reverse() method #35091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Dec 23, 2019
2 tasks
c5084ca to
da17343
Compare
nicolas-grekas
approved these changes
Dec 26, 2019
da17343 to
c369598
Compare
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 26, 2019
This PR was merged into the 5.1-dev branch. Discussion ---------- [String] Add the reverse() method | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Allows to easily reverse a string since `mb_strrev` does not exist. Commits ------- c369598 [String] Add the reverse method
fabpot
added a commit
that referenced
this pull request
May 5, 2020
This PR was merged into the 5.1-dev branch. Discussion ---------- [Inflector][String] Move Inflector in String | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | yes | Tickets | https://github.com/orgs/symfony/projects/1#card-30499514 | License | MIT | Doc PR | - Needs #35091. Should we have a standalone inflector (like the Slugger) or 2 new methods (pluralize and singularize) on the AbstractString class? I implemented both but since we only handle English I finally preferred the first one. TODO (after the "move" is OK): - [x] Deprecate the Inflector component - [x] Use the String inflector in Symfony's code Commits ------- 9c6a5c0 [String] Move Inflector in String
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to easily reverse a string since
mb_strrevdoes not exist.