[FrameworkBundle] Do not throw exception on value generate key #35099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazux
approved these changes
Dec 29, 2019
|
Thank you @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 9, 2020
… key (jderusse) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Do not throw exception on value generate key | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A When using env variable instead of key files and creating a new Secret, the check in `generateKeys` (called by the command `SecretsSetCommand`) prevents generating a secret. reproducer: ``` $ rm config/secrets/prod/prod.decrypt.private.php $ export SYMFONY_DECRYPTION_SECRET=XXX $ ./bin/console secret:set FOO In SodiumVault.php line 50: Cannot generate keys when a decryption key has been provided while instantiating the vault. ``` This PR converts the exception in a warning message. Commits ------- 2f608b4 Do not throw exception on valut generate key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using env variable instead of key files and creating a new Secret, the check in
generateKeys(called by the commandSecretsSetCommand) prevents generating a secret.reproducer:
This PR converts the exception in a warning message.