Skip to content

[Messenger] Log sender alias in SendMessageMiddleware #35104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Dec 25, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
License MIT

This makes it easier to read which sender alias was used.

- Sending message Domain\Event\PaymentFlow\PaymentFlowFailedEvent with Symfony\Component\Messenger\Transport\Doctrine\DoctrineTransport
+ Sending message Domain\Event\PaymentFlow\PaymentFlowFailedEvent with async sender using Symfony\Component\Messenger\Transport\Doctrine\DoctrineTransport

This makes it easier to read which sender alias was used.
@ruudk ruudk requested a review from sroze as a code owner December 25, 2019 14:47
@nicolas-grekas nicolas-grekas changed the title Log sender alias in SendMessageMiddleware [Messenger] Log sender alias in SendMessageMiddleware Dec 26, 2019
@nicolas-grekas nicolas-grekas added this to the next milestone Dec 26, 2019
@fabpot
Copy link
Member

fabpot commented Jan 7, 2020

Thank you @ruudk.

fabpot added a commit that referenced this pull request Jan 7, 2020
…(ruudk)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[Messenger] Log sender alias in SendMessageMiddleware

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| License       | MIT

This makes it easier to read which sender alias was used.

```diff
- Sending message Domain\Event\PaymentFlow\PaymentFlowFailedEvent with Symfony\Component\Messenger\Transport\Doctrine\DoctrineTransport
+ Sending message Domain\Event\PaymentFlow\PaymentFlowFailedEvent with async sender using Symfony\Component\Messenger\Transport\Doctrine\DoctrineTransport
```

Commits
-------

4e6626c Log sender alias in SendMessageMiddleware
@fabpot fabpot merged commit 4e6626c into symfony:master Jan 7, 2020
@ruudk ruudk deleted the patch-3 branch January 8, 2020 08:00
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants